Răsfoiți Sursa

meta: removed meta_type::base(id_type) because pointless

Michele Caini 3 ani în urmă
părinte
comite
358a9742c5
2 a modificat fișierele cu 2 adăugiri și 16 ștergeri
  1. 0 9
      src/entt/meta/meta.hpp
  2. 2 7
      test/entt/meta/meta_type.cpp

+ 0 - 9
src/entt/meta/meta.hpp

@@ -1144,15 +1144,6 @@ public:
         return {node->base, nullptr};
         return {node->base, nullptr};
     }
     }
 
 
-    /**
-     * @brief Lookup function for registered base meta types.
-     * @param id Unique identifier.
-     * @return The registered base meta type for the given identifier, if any.
-     */
-    [[nodiscard]] meta_type base(const id_type id) const {
-        return internal::find_by<&node_type::base>(id, node);
-    }
-
     /**
     /**
      * @brief Returns a range to visit registered top-level meta data.
      * @brief Returns a range to visit registered top-level meta data.
      * @return An iterable range to visit registered top-level meta data.
      * @return An iterable range to visit registered top-level meta data.

+ 2 - 7
test/entt/meta/meta_type.cpp

@@ -292,18 +292,13 @@ TEST_F(MetaType, TemplateInfo) {
 
 
 TEST_F(MetaType, Base) {
 TEST_F(MetaType, Base) {
     using namespace entt::literals;
     using namespace entt::literals;
-
     auto type = entt::resolve<derived_t>();
     auto type = entt::resolve<derived_t>();
-    bool iterate = false;
+
+    ASSERT_NE(type.base().cbegin(), type.base().cend());
 
 
     for(auto curr: type.base()) {
     for(auto curr: type.base()) {
         ASSERT_EQ(curr, entt::resolve<base_t>());
         ASSERT_EQ(curr, entt::resolve<base_t>());
-        iterate = true;
     }
     }
-
-    ASSERT_TRUE(iterate);
-    ASSERT_EQ(type.base("base"_hs), entt::resolve<base_t>());
-    ASSERT_FALSE(type.base("esabe"_hs));
 }
 }
 
 
 TEST_F(MetaType, Ctor) {
 TEST_F(MetaType, Ctor) {