Browse Source

test: [[nodiscard]] and other linter related stuff

Michele Caini 2 years ago
parent
commit
5a2be7d6eb
2 changed files with 12 additions and 12 deletions
  1. 8 8
      test/entt/meta/meta_any.cpp
  2. 4 4
      test/entt/meta/meta_utility.cpp

+ 8 - 8
test/entt/meta/meta_any.cpp

@@ -105,7 +105,7 @@ TEST_F(MetaAny, SBO) {
     entt::meta_any any{'c'};
 
     ASSERT_TRUE(any);
-    ASSERT_TRUE(any.owner());
+    ASSERT_TRUE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::owner);
     ASSERT_FALSE(any.try_cast<std::size_t>());
     ASSERT_EQ(any.cast<char>(), 'c');
@@ -119,12 +119,12 @@ TEST_F(MetaAny, NoSBO) {
     entt::meta_any any{instance};
 
     ASSERT_TRUE(any);
-    ASSERT_TRUE(any.owner());
+    ASSERT_TRUE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::owner);
     ASSERT_FALSE(any.try_cast<std::size_t>());
     ASSERT_EQ(any.cast<fat_t>(), instance);
     ASSERT_NE(any.data(), nullptr);
-    ASSERT_EQ(any, entt::meta_any{instance}); 
+    ASSERT_EQ(any, entt::meta_any{instance});
     ASSERT_NE(any, fat_t{});
 }
 
@@ -165,7 +165,7 @@ TEST_F(MetaAny, SBOAsRefConstruction) {
     auto any = entt::forward_as_meta(value);
 
     ASSERT_TRUE(any);
-    ASSERT_FALSE(any.owner());
+    ASSERT_FALSE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::ref);
     ASSERT_EQ(any.type(), entt::resolve<int>());
 
@@ -202,7 +202,7 @@ TEST_F(MetaAny, SBOAsConstRefConstruction) {
     auto any = entt::forward_as_meta(value);
 
     ASSERT_TRUE(any);
-    ASSERT_FALSE(any.owner());
+    ASSERT_FALSE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::cref);
     ASSERT_EQ(any.type(), entt::resolve<int>());
 
@@ -435,7 +435,7 @@ TEST_F(MetaAny, NoSBOAsRefConstruction) {
     auto any = entt::forward_as_meta(instance);
 
     ASSERT_TRUE(any);
-    ASSERT_FALSE(any.owner());
+    ASSERT_FALSE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::ref);
     ASSERT_EQ(any.type(), entt::resolve<fat_t>());
 
@@ -470,7 +470,7 @@ TEST_F(MetaAny, NoSBOAsConstRefConstruction) {
     auto any = entt::forward_as_meta(instance);
 
     ASSERT_TRUE(any);
-    ASSERT_FALSE(any.owner());
+    ASSERT_FALSE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::cref);
     ASSERT_EQ(any.type(), entt::resolve<fat_t>());
 
@@ -708,7 +708,7 @@ TEST_F(MetaAny, VoidInPlaceTypeConstruction) {
     entt::meta_any any{std::in_place_type<void>};
 
     ASSERT_TRUE(any);
-    ASSERT_TRUE(any.owner());
+    ASSERT_TRUE(any.owner()); // NOLINT
     ASSERT_EQ(any.policy(), entt::meta_any_policy::owner);
     ASSERT_FALSE(any.try_cast<char>());
     ASSERT_EQ(any.data(), nullptr);

+ 4 - 4
test/entt/meta/meta_utility.cpp

@@ -13,7 +13,7 @@ struct clazz {
         member = v;
     }
 
-    int getter() const {
+    [[nodiscard]] int getter() const {
         return member;
     }
 
@@ -21,7 +21,7 @@ struct clazz {
         instance.member = v;
     }
 
-    static int static_getter(const clazz &instance) {
+    [[nodiscard]] static int static_getter(const clazz &instance) {
         return instance.member;
     }
 
@@ -29,11 +29,11 @@ struct clazz {
         value = 0;
     }
 
-    static int get_value() {
+    [[nodiscard]] static int get_value() {
         return value;
     }
 
-    static clazz factory(int v) {
+    [[nodiscard]] static clazz factory(int v) {
         clazz instance{};
         instance.member = v;
         return instance;