Просмотр исходного кода

entity: removed unused constructors from range iterators (being default constructible isn't a requirement for input iterators)

Michele Caini 5 лет назад
Родитель
Сommit
725e9feb68
2 измененных файлов с 8 добавлено и 16 удалено
  1. 5 9
      src/entt/entity/group.hpp
  2. 3 7
      src/entt/entity/view.hpp

+ 5 - 9
src/entt/entity/group.hpp

@@ -98,8 +98,6 @@ class basic_group<Entity, exclude_t<Exclude...>, get_t<Get...>> {
             ));
             using iterator_category = std::input_iterator_tag;
 
-            range_iterator() ENTT_NOEXCEPT = default;
-
             range_iterator & operator++() ENTT_NOEXCEPT {
                 return ++it, *this;
             }
@@ -122,8 +120,8 @@ class basic_group<Entity, exclude_t<Exclude...>, get_t<Get...>> {
             }
 
         private:
-            it_type it;
-            ref_type pools;
+            it_type it{};
+            ref_type pools{};
         };
 
         group_range(const sparse_set<Entity> &ref, std::tuple<pool_type<Get> *...> gpools)
@@ -607,8 +605,6 @@ class basic_group<Entity, exclude_t<Exclude...>, get_t<Get...>, Owned...> {
             ));
             using iterator_category = std::input_iterator_tag;
 
-            range_iterator() ENTT_NOEXCEPT = default;
-
             range_iterator & operator++() ENTT_NOEXCEPT {
                 return ++it, std::apply([](auto &&... curr) { (++curr, ...); }, owned), *this;
             }
@@ -635,9 +631,9 @@ class basic_group<Entity, exclude_t<Exclude...>, get_t<Get...>, Owned...> {
             }
 
         private:
-            it_type it;
-            owned_type owned;
-            get_type get;
+            it_type it{};
+            owned_type owned{};
+            get_type get{};
         };
 
         group_range(std::tuple<pool_type<Owned> *..., pool_type<Get> *...> cpools, const std::size_t &extent)

+ 3 - 7
src/entt/entity/view.hpp

@@ -175,8 +175,6 @@ class basic_view<Entity, exclude_t<Exclude...>, Component...> {
             ));
             using iterator_category = std::input_iterator_tag;
 
-            range_iterator() ENTT_NOEXCEPT = default;
-
             range_iterator & operator++() ENTT_NOEXCEPT {
                 return ++it, *this;
             }
@@ -199,8 +197,8 @@ class basic_view<Entity, exclude_t<Exclude...>, Component...> {
             }
 
         private:
-            view_iterator it;
-            const ref_type pools;
+            view_iterator it{};
+            const ref_type pools{};
         };
 
         view_range(view_iterator from, view_iterator to, std::tuple<pool_type<Component> *...> ref)
@@ -644,8 +642,6 @@ class basic_view<Entity, exclude_t<>, Component> {
             using reference = std::conditional_t<ENTT_IS_EMPTY(Component), std::tuple<Entity>, std::tuple<Entity, Component &>>;
             using iterator_category = std::input_iterator_tag;
 
-            range_iterator() ENTT_NOEXCEPT = default;
-
             range_iterator & operator++() ENTT_NOEXCEPT {
                 return std::apply([](auto &&... curr) { (++curr, ...); }, it), *this;
             }
@@ -668,7 +664,7 @@ class basic_view<Entity, exclude_t<>, Component> {
             }
 
         private:
-            it_type it;
+            it_type it{};
         };
 
         view_range(pool_type &ref)