Kaynağa Gözat

test: reintroduce meaningful checks behind a NOLINT directive

Michele Caini 2 yıl önce
ebeveyn
işleme
854dedfda0

+ 4 - 4
test/entt/container/dense_map.cpp

@@ -145,15 +145,14 @@ TEST(DenseMap, Copy) {
 
 TEST(DenseMap, Move) {
     entt::dense_map<std::size_t, std::size_t, entt::identity> map;
-    const auto load_factor = map.max_load_factor() - .05f;
-
-    map.max_load_factor(load_factor);
+    map.max_load_factor(map.max_load_factor() - .05f);
     map.emplace(3u, 42u);
 
     entt::dense_map<std::size_t, std::size_t, entt::identity> other{std::move(map)};
 
+    ASSERT_EQ(map.size(), 0u); // NOLINT
     ASSERT_TRUE(other.contains(3u));
-    ASSERT_EQ(other.max_load_factor(), load_factor);
+    ASSERT_EQ(map.max_load_factor(), other.max_load_factor());
 
     map = other;
     map.emplace(1u, 99u);
@@ -161,6 +160,7 @@ TEST(DenseMap, Move) {
     other.emplace(0u, 0u);
     other = std::move(map);
 
+    ASSERT_EQ(map.size(), 0u); // NOLINT
     ASSERT_TRUE(other.contains(3u));
     ASSERT_TRUE(other.contains(1u));
     ASSERT_TRUE(other.contains(11u));

+ 4 - 4
test/entt/container/dense_set.cpp

@@ -139,15 +139,14 @@ TEST(DenseSet, Copy) {
 
 TEST(DenseSet, Move) {
     entt::dense_set<std::size_t, entt::identity> set;
-    const auto load_factor = set.max_load_factor() - .05f;
-
-    set.max_load_factor(load_factor);
+    set.max_load_factor(set.max_load_factor() - .05f);
     set.emplace(3u);
 
     entt::dense_set<std::size_t, entt::identity> other{std::move(set)};
 
+    ASSERT_EQ(set.size(), 0u); // NOLINT
     ASSERT_TRUE(other.contains(3u));
-    ASSERT_EQ(other.max_load_factor(), load_factor);
+    ASSERT_EQ(set.max_load_factor(), other.max_load_factor());
 
     set = other;
     set.emplace(1u);
@@ -155,6 +154,7 @@ TEST(DenseSet, Move) {
     other.emplace(0u);
     other = std::move(set);
 
+    ASSERT_EQ(set.size(), 0u); // NOLINT
     ASSERT_TRUE(other.contains(3u));
     ASSERT_TRUE(other.contains(1u));
     ASSERT_TRUE(other.contains(11u));